| From 7011e660938fc44ed86319c18a5954e95a82ab3e Mon Sep 17 00:00:00 2001 |
| From: Dan Rosenberg <drosenberg@vsecurity.com> |
| Date: Wed, 15 Sep 2010 11:43:28 +0000 |
| Subject: drivers/net/usb/hso.c: prevent reading uninitialized memory |
| |
| From: Dan Rosenberg <drosenberg@vsecurity.com> |
| |
| commit 7011e660938fc44ed86319c18a5954e95a82ab3e upstream. |
| |
| Fixed formatting (tabs and line breaks). |
| |
| The TIOCGICOUNT device ioctl allows unprivileged users to read |
| uninitialized stack memory, because the "reserved" member of the |
| serial_icounter_struct struct declared on the stack in hso_get_count() |
| is not altered or zeroed before being copied back to the user. This |
| patch takes care of it. |
| |
| Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/net/usb/hso.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/net/usb/hso.c |
| +++ b/drivers/net/usb/hso.c |
| @@ -1634,6 +1634,8 @@ static int hso_get_count(struct hso_seri |
| struct uart_icount cnow; |
| struct hso_tiocmget *tiocmget = serial->tiocmget; |
| |
| + memset(&icount, 0, sizeof(struct serial_icounter_struct)); |
| + |
| if (!tiocmget) |
| return -ENOENT; |
| spin_lock_irq(&serial->serial_lock); |
