| From f375fc520d4df0cd9fcb570f33c103c6c0311f9e Mon Sep 17 00:00:00 2001 |
| From: Daniel Mack <zonque@gmail.com> |
| Date: Wed, 21 Aug 2013 11:17:21 +0200 |
| Subject: usb: ehci-mxc: check for pdata before dereferencing |
| |
| From: Daniel Mack <zonque@gmail.com> |
| |
| commit f375fc520d4df0cd9fcb570f33c103c6c0311f9e upstream. |
| |
| Commit 7e8d5cd93fac ("USB: Add EHCI support for MX27 and MX31 based |
| boards") introduced code that could potentially lead to a NULL pointer |
| dereference on driver removal. |
| |
| Fix this by checking for the value of pdata before dereferencing it. |
| |
| Signed-off-by: Daniel Mack <zonque@gmail.com> |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/host/ehci-mxc.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/usb/host/ehci-mxc.c |
| +++ b/drivers/usb/host/ehci-mxc.c |
| @@ -184,7 +184,7 @@ static int ehci_mxc_drv_remove(struct pl |
| if (pdata && pdata->exit) |
| pdata->exit(pdev); |
| |
| - if (pdata->otg) |
| + if (pdata && pdata->otg) |
| usb_phy_shutdown(pdata->otg); |
| |
| clk_disable_unprepare(priv->usbclk); |
