| From 9b389a8a022110b4bc055a19b888283544d9eba6 Mon Sep 17 00:00:00 2001 |
| From: Takashi Iwai <tiwai@suse.de> |
| Date: Mon, 28 Oct 2013 11:24:23 +0100 |
| Subject: ALSA: 6fire: Fix probe of multiple cards |
| |
| From: Takashi Iwai <tiwai@suse.de> |
| |
| commit 9b389a8a022110b4bc055a19b888283544d9eba6 upstream. |
| |
| The probe code of snd-usb-6fire driver overrides the devices[] pointer |
| wrongly without checking whether it's already occupied or not. This |
| would screw up the device disconnection later. |
| |
| Spotted by coverity CID 141423. |
| |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/usb/6fire/chip.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/sound/usb/6fire/chip.c |
| +++ b/sound/usb/6fire/chip.c |
| @@ -101,7 +101,7 @@ static int usb6fire_chip_probe(struct us |
| usb_set_intfdata(intf, chips[i]); |
| mutex_unlock(®ister_mutex); |
| return 0; |
| - } else if (regidx < 0) |
| + } else if (!devices[i] && regidx < 0) |
| regidx = i; |
| } |
| if (regidx < 0) { |