| From f9fa1887dcf26bd346665a6ae3d3f53dec54cba1 Mon Sep 17 00:00:00 2001 |
| From: Alexey Khoroshilov <khoroshilov@ispras.ru> |
| Date: Sat, 21 Nov 2015 00:36:44 +0300 |
| Subject: USB: whci-hcd: add check for dma mapping error |
| |
| From: Alexey Khoroshilov <khoroshilov@ispras.ru> |
| |
| commit f9fa1887dcf26bd346665a6ae3d3f53dec54cba1 upstream. |
| |
| qset_fill_page_list() do not check for dma mapping errors. |
| |
| Found by Linux Driver Verification project (linuxtesting.org). |
| |
| Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/host/whci/qset.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| --- a/drivers/usb/host/whci/qset.c |
| +++ b/drivers/usb/host/whci/qset.c |
| @@ -377,6 +377,10 @@ static int qset_fill_page_list(struct wh |
| if (std->pl_virt == NULL) |
| return -ENOMEM; |
| std->dma_addr = dma_map_single(whc->wusbhc.dev, std->pl_virt, pl_len, DMA_TO_DEVICE); |
| + if (dma_mapping_error(whc->wusbhc.dev, std->dma_addr)) { |
| + kfree(std->pl_virt); |
| + return -EFAULT; |
| + } |
| |
| for (p = 0; p < std->num_pointers; p++) { |
| std->pl_virt[p].buf_ptr = cpu_to_le64(dma_addr); |