| From 67a3b63a54cbe18944191f43d644686731cf30c7 Mon Sep 17 00:00:00 2001 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Tue, 5 Sep 2017 09:47:26 +0200 |
| Subject: drm: gma500: fix logic error |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| commit 67a3b63a54cbe18944191f43d644686731cf30c7 upstream. |
| |
| gcc-8 points out a condition that almost certainly doesn't |
| do what the author had in mind: |
| |
| drivers/gpu/drm/gma500/mdfld_intel_display.c: In function 'mdfldWaitForPipeEnable': |
| drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] |
| |
| This changes it to a simple bit mask operation to check |
| whether the bit is set. |
| |
| Fixes: 026abc333205 ("gma500: initial medfield merge") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20170905074741.435324-1-arnd@arndb.de |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c |
| +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c |
| @@ -99,7 +99,7 @@ void mdfldWaitForPipeEnable(struct drm_d |
| /* Wait for for the pipe enable to take effect. */ |
| for (count = 0; count < COUNT_MAX; count++) { |
| temp = REG_READ(map->conf); |
| - if ((temp & PIPEACONF_PIPE_STATE) == 1) |
| + if (temp & PIPEACONF_PIPE_STATE) |
| break; |
| } |
| } |
