| From d7793798d572e1f2d15512d49164935e109c2973 Mon Sep 17 00:00:00 2001 |
| From: Yangtao Li <tiny.windzz@gmail.com> |
| Date: Thu, 22 Nov 2018 07:34:41 -0500 |
| Subject: net: amd: add missing of_node_put() |
| |
| [ Upstream commit c44c749d3b6fdfca39002e7e48e03fe9f9fe37a3 ] |
| |
| of_find_node_by_path() acquires a reference to the node |
| returned by it and that reference needs to be dropped by its caller. |
| This place doesn't do that, so fix it. |
| |
| Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/amd/sunlance.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/amd/sunlance.c b/drivers/net/ethernet/amd/sunlance.c |
| index 5e4273b7aa27..2bac37b9b4d3 100644 |
| --- a/drivers/net/ethernet/amd/sunlance.c |
| +++ b/drivers/net/ethernet/amd/sunlance.c |
| @@ -1419,7 +1419,7 @@ static int sparc_lance_probe_one(struct platform_device *op, |
| |
| prop = of_get_property(nd, "tpe-link-test?", NULL); |
| if (!prop) |
| - goto no_link_test; |
| + goto node_put; |
| |
| if (strcmp(prop, "true")) { |
| printk(KERN_NOTICE "SunLance: warning: overriding option " |
| @@ -1428,6 +1428,8 @@ static int sparc_lance_probe_one(struct platform_device *op, |
| "to ecd@skynet.be\n"); |
| auxio_set_lte(AUXIO_LTE_ON); |
| } |
| +node_put: |
| + of_node_put(nd); |
| no_link_test: |
| lp->auto_select = 1; |
| lp->tpe = 0; |
| -- |
| 2.19.1 |
| |
