| From foo@baz Mon Dec 3 10:41:36 CET 2018 |
| From: Pan Bian <bianpan2016@163.com> |
| Date: Wed, 28 Nov 2018 14:53:19 +0800 |
| Subject: rapidio/rionet: do not free skb before reading its length |
| |
| From: Pan Bian <bianpan2016@163.com> |
| |
| [ Upstream commit cfc435198f53a6fa1f656d98466b24967ff457d0 ] |
| |
| skb is freed via dev_kfree_skb_any, however, skb->len is read then. This |
| may result in a use-after-free bug. |
| |
| Fixes: e6161d64263 ("rapidio/rionet: rework driver initialization and removal") |
| Signed-off-by: Pan Bian <bianpan2016@163.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/rionet.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/rionet.c |
| +++ b/drivers/net/rionet.c |
| @@ -215,9 +215,9 @@ static int rionet_start_xmit(struct sk_b |
| * it just report sending a packet to the target |
| * (without actual packet transfer). |
| */ |
| - dev_kfree_skb_any(skb); |
| ndev->stats.tx_packets++; |
| ndev->stats.tx_bytes += skb->len; |
| + dev_kfree_skb_any(skb); |
| } |
| } |
| |
