| From foo@baz Tue Nov 28 10:58:31 CET 2017 |
| From: Pan Bian <bianpan2016@163.com> |
| Date: Sat, 3 Dec 2016 21:44:30 +0800 |
| Subject: staging: iio: cdc: fix improper return value |
| |
| From: Pan Bian <bianpan2016@163.com> |
| |
| |
| [ Upstream commit 91ca1a8c584f55857b1f6ab20a1d3a1ce7a559bb ] |
| |
| At the end of function ad7150_write_event_config(), directly returns 0. |
| As a result, the errors will be ignored by the callers. It may be better |
| to return variable "ret". |
| |
| Signed-off-by: Pan Bian <bianpan2016@163.com> |
| Signed-off-by: Jonathan Cameron <jic23@kernel.org> |
| Signed-off-by: Sasha Levin <alexander.levin@verizon.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/staging/iio/cdc/ad7150.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/staging/iio/cdc/ad7150.c |
| +++ b/drivers/staging/iio/cdc/ad7150.c |
| @@ -275,7 +275,7 @@ static int ad7150_write_event_config(str |
| error_ret: |
| mutex_unlock(&chip->state_lock); |
| |
| - return 0; |
| + return ret; |
| } |
| |
| static int ad7150_read_event_value(struct iio_dev *indio_dev, |
