| From 912b9ac683b112615d5605686f1dc086402ce9f7 Mon Sep 17 00:00:00 2001 |
| From: Shane Huang <shane.huang@amd.com> |
| Date: Sat, 8 Jun 2013 16:00:16 +0800 |
| Subject: ahci: remove pmp link online check in FBS EH |
| |
| From: Shane Huang <shane.huang@amd.com> |
| |
| commit 912b9ac683b112615d5605686f1dc086402ce9f7 upstream. |
| |
| ata_link_online() check in ahci_error_intr() is unnecessary, it should |
| be removed otherwise may lead to lockup with FBS enabled PMP. |
| http://marc.info/?l=linux-ide&m=137050421603272&w=2 |
| |
| Reported-by: Yu Liu <liuyu.ac@gmail.com> |
| Signed-off-by: Shane Huang <shane.huang@amd.com> |
| Signed-off-by: Tejun Heo <tj@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/ata/libahci.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/drivers/ata/libahci.c |
| +++ b/drivers/ata/libahci.c |
| @@ -1560,8 +1560,7 @@ static void ahci_error_intr(struct ata_p |
| u32 fbs = readl(port_mmio + PORT_FBS); |
| int pmp = fbs >> PORT_FBS_DWE_OFFSET; |
| |
| - if ((fbs & PORT_FBS_SDE) && (pmp < ap->nr_pmp_links) && |
| - ata_link_online(&ap->pmp_link[pmp])) { |
| + if ((fbs & PORT_FBS_SDE) && (pmp < ap->nr_pmp_links)) { |
| link = &ap->pmp_link[pmp]; |
| fbs_need_dec = true; |
| } |
