| From 80e5f89da3ab949fbbf1cae01dfaea29f5483a75 Mon Sep 17 00:00:00 2001 |
| From: Huacai Chen <chenhc@lemote.com> |
| Date: Tue, 31 Mar 2020 14:18:08 +0800 |
| Subject: drm/qxl: Use correct notify port address when creating cursor ring |
| |
| From: Huacai Chen <chenhc@lemote.com> |
| |
| commit 80e5f89da3ab949fbbf1cae01dfaea29f5483a75 upstream. |
| |
| The command ring and cursor ring use different notify port addresses |
| definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in |
| qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring |
| and cursor ring. This doesn't cause any problems now, because QEMU's |
| behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same. |
| However, QEMU's behavior may be change in future, so let's fix it. |
| |
| P.S.: In the X.org QXL driver, the notify port address of cursor ring |
| is correct. |
| |
| Signed-off-by: Huacai Chen <chenhc@lemote.com> |
| Cc: <stable@vger.kernel.org> |
| Link: http://patchwork.freedesktop.org/patch/msgid/1585635488-17507-1-git-send-email-chenhc@lemote.com |
| Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpu/drm/qxl/qxl_kms.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/gpu/drm/qxl/qxl_kms.c |
| +++ b/drivers/gpu/drm/qxl/qxl_kms.c |
| @@ -181,7 +181,7 @@ int qxl_device_init(struct qxl_device *q |
| &(qdev->ram_header->cursor_ring_hdr), |
| sizeof(struct qxl_command), |
| QXL_CURSOR_RING_SIZE, |
| - qdev->io_base + QXL_IO_NOTIFY_CMD, |
| + qdev->io_base + QXL_IO_NOTIFY_CURSOR, |
| false, |
| &qdev->cursor_event); |
| |
