| From 73c4e8c48e13eab54b25c2b12e2deee3f2076344 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 27 May 2020 19:24:42 -0700 |
| Subject: scsi: ufs: Don't update urgent bkops level when toggling auto bkops |
| |
| From: Can Guo <cang@codeaurora.org> |
| |
| [ Upstream commit be32acff43800c87dc5c707f5d47cc607b76b653 ] |
| |
| Urgent bkops level is used to compare against actual bkops status read from |
| UFS device. Urgent bkops level is set during initialization and might be |
| updated in exception event handler during runtime. But it should not be |
| updated to the actual bkops status every time when auto bkops is toggled. |
| Otherwise, if urgent bkops level is updated to 0, auto bkops shall always |
| be kept enabled. |
| |
| Link: https://lore.kernel.org/r/1590632686-17866-1-git-send-email-cang@codeaurora.org |
| Fixes: 24366c2afbb0 ("scsi: ufs: Recheck bkops level if bkops is disabled") |
| Reviewed-by: Stanley Chu <stanley.chu@mediatek.com> |
| Signed-off-by: Can Guo <cang@codeaurora.org> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/ufs/ufshcd.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c |
| index 3a98e5a1d830c..1e2a97a10033b 100644 |
| --- a/drivers/scsi/ufs/ufshcd.c |
| +++ b/drivers/scsi/ufs/ufshcd.c |
| @@ -4890,7 +4890,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba, |
| err = ufshcd_enable_auto_bkops(hba); |
| else |
| err = ufshcd_disable_auto_bkops(hba); |
| - hba->urgent_bkops_lvl = curr_status; |
| out: |
| return err; |
| } |
| -- |
| 2.25.1 |
| |
