| From a1860851784c98bd2b6a7ddecfde9ebac99984aa Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 9 Jan 2021 13:43:08 +0100 |
| Subject: i2c: octeon: check correct size of maximum RECV_LEN packet |
| |
| From: Wolfram Sang <wsa+renesas@sang-engineering.com> |
| |
| [ Upstream commit 1b2cfa2d1dbdcc3b6dba1ecb7026a537a1d7277f ] |
| |
| I2C_SMBUS_BLOCK_MAX defines already the maximum number as defined in the |
| SMBus 2.0 specs. No reason to add one to it. |
| |
| Fixes: 886f6f8337dd ("i2c: octeon: Support I2C_M_RECV_LEN") |
| Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> |
| Reviewed-by: Robert Richter <rric@kernel.org> |
| Signed-off-by: Wolfram Sang <wsa@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/i2c/busses/i2c-octeon-core.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon-core.c |
| index 1d87757990568..cd512a93f3ba9 100644 |
| --- a/drivers/i2c/busses/i2c-octeon-core.c |
| +++ b/drivers/i2c/busses/i2c-octeon-core.c |
| @@ -346,7 +346,7 @@ static int octeon_i2c_read(struct octeon_i2c *i2c, int target, |
| if (result) |
| return result; |
| if (recv_len && i == 0) { |
| - if (data[i] > I2C_SMBUS_BLOCK_MAX + 1) |
| + if (data[i] > I2C_SMBUS_BLOCK_MAX) |
| return -EPROTO; |
| length += data[i]; |
| } |
| -- |
| 2.27.0 |
| |
