| From f477a538c14d07f8c45e554c8c5208d588514e98 Mon Sep 17 00:00:00 2001 |
| From: Necip Fazil Yildiran <fazilyildiran@gmail.com> |
| Date: Thu, 17 Sep 2020 18:45:48 +0300 |
| Subject: sh: dma: fix kconfig dependency for G2_DMA |
| |
| From: Necip Fazil Yildiran <fazilyildiran@gmail.com> |
| |
| commit f477a538c14d07f8c45e554c8c5208d588514e98 upstream. |
| |
| When G2_DMA is enabled and SH_DMA is disabled, it results in the following |
| Kbuild warning: |
| |
| WARNING: unmet direct dependencies detected for SH_DMA_API |
| Depends on [n]: SH_DMA [=n] |
| Selected by [y]: |
| - G2_DMA [=y] && SH_DREAMCAST [=y] |
| |
| The reason is that G2_DMA selects SH_DMA_API without depending on or |
| selecting SH_DMA while SH_DMA_API depends on SH_DMA. |
| |
| When G2_DMA was first introduced with commit 40f49e7ed77f |
| ("sh: dma: Make G2 DMA configurable."), this wasn't an issue since |
| SH_DMA_API didn't have such dependency, and this way was the only way to |
| enable it since SH_DMA_API was non-visible. However, later SH_DMA_API was |
| made visible and dependent on SH_DMA with commit d8902adcc1a9 |
| ("dmaengine: sh: Add Support SuperH DMA Engine driver"). |
| |
| Let G2_DMA depend on SH_DMA_API instead to avoid Kbuild issues. |
| |
| Fixes: d8902adcc1a9 ("dmaengine: sh: Add Support SuperH DMA Engine driver") |
| Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com> |
| Signed-off-by: Rich Felker <dalias@libc.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| arch/sh/drivers/dma/Kconfig | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/arch/sh/drivers/dma/Kconfig |
| +++ b/arch/sh/drivers/dma/Kconfig |
| @@ -63,8 +63,7 @@ config PVR2_DMA |
| |
| config G2_DMA |
| tristate "G2 Bus DMA support" |
| - depends on SH_DREAMCAST |
| - select SH_DMA_API |
| + depends on SH_DREAMCAST && SH_DMA_API |
| help |
| This enables support for the DMA controller for the Dreamcast's |
| G2 bus. Drivers that want this will generally enable this on |