| From f85031fcbb6bfc99616b8420b8bccfbdee1af62d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 13 Jan 2021 19:33:33 +0100 |
| Subject: drm/msm/a5xx: Remove overwriting A5XX_PC_DBG_ECO_CNTL register |
| |
| From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> |
| |
| [ Upstream commit 8f03c30cb814213e36032084a01f49a9e604a3e3 ] |
| |
| The PC_DBG_ECO_CNTL register on the Adreno A5xx family gets |
| programmed to some different values on a per-model basis. |
| At least, this is what we intend to do here; |
| |
| Unfortunately, though, this register is being overwritten with a |
| static magic number, right after applying the GPU-specific |
| configuration (including the GPU-specific quirks) and that is |
| effectively nullifying the efforts. |
| |
| Let's remove the redundant and wrong write to the PC_DBG_ECO_CNTL |
| register in order to retain the wanted configuration for the |
| target GPU. |
| |
| Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> |
| Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> |
| Signed-off-by: Rob Clark <robdclark@chromium.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c |
| index f1aaa76cc2e4..92e767f3cc16 100644 |
| --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c |
| +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c |
| @@ -472,8 +472,6 @@ static int a5xx_hw_init(struct msm_gpu *gpu) |
| if (adreno_gpu->info->quirks & ADRENO_QUIRK_TWO_PASS_USE_WFI) |
| gpu_rmw(gpu, REG_A5XX_PC_DBG_ECO_CNTL, 0, (1 << 8)); |
| |
| - gpu_write(gpu, REG_A5XX_PC_DBG_ECO_CNTL, 0xc0200100); |
| - |
| /* Enable USE_RETENTION_FLOPS */ |
| gpu_write(gpu, REG_A5XX_CP_CHICKEN_DBG, 0x02000000); |
| |
| -- |
| 2.30.1 |
| |
