| From 4f8c5edcd7fd72205ac225034655ce3acb90e045 Mon Sep 17 00:00:00 2001 |
| From: Po-Hsu Lin <po-hsu.lin@canonical.com> |
| Date: Thu, 18 Apr 2019 19:57:25 +0800 |
| Subject: selftests/net: correct the return value for run_netsocktests |
| |
| [ Upstream commit 30c04d796b693e22405c38e9b78e9a364e4c77e6 ] |
| |
| The run_netsocktests will be marked as passed regardless the actual test |
| result from the ./socket: |
| |
| selftests: net: run_netsocktests |
| ======================================== |
| -------------------- |
| running socket test |
| -------------------- |
| [FAIL] |
| ok 1..6 selftests: net: run_netsocktests [PASS] |
| |
| This is because the test script itself has been successfully executed. |
| Fix this by exit 1 when the test failed. |
| |
| Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/testing/selftests/net/run_netsocktests | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/tools/testing/selftests/net/run_netsocktests b/tools/testing/selftests/net/run_netsocktests |
| index b093f39c298c3..14e41faf2c574 100755 |
| --- a/tools/testing/selftests/net/run_netsocktests |
| +++ b/tools/testing/selftests/net/run_netsocktests |
| @@ -7,7 +7,7 @@ echo "--------------------" |
| ./socket |
| if [ $? -ne 0 ]; then |
| echo "[FAIL]" |
| + exit 1 |
| else |
| echo "[PASS]" |
| fi |
| - |
| -- |
| 2.20.1 |
| |