| From 8d4514173211586c6238629b1ef1e071927735f5 Mon Sep 17 00:00:00 2001 |
| From: Gregory CLEMENT <gregory.clement@free-electrons.com> |
| Date: Wed, 12 Jul 2017 13:23:11 +0200 |
| Subject: ARM: dts: armada-38x: Fix irq type for pca955 |
| |
| From: Gregory CLEMENT <gregory.clement@free-electrons.com> |
| |
| commit 8d4514173211586c6238629b1ef1e071927735f5 upstream. |
| |
| As written in the datasheet the PCA955 can only handle low level irq and |
| not edge irq. |
| |
| Without this fix the interrupt is not usable for pca955: the gpio-pca953x |
| driver already set the irq type as low level which is incompatible with |
| edge type, then the kernel prevents using the interrupt: |
| |
| "irq: type mismatch, failed to map hwirq-18 for |
| /soc/internal-regs/gpio@18100!" |
| |
| Fixes: 928413bd859c ("ARM: mvebu: Add Armada 388 General Purpose |
| Development Board support") |
| Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| arch/arm/boot/dts/armada-388-gp.dts | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/arch/arm/boot/dts/armada-388-gp.dts |
| +++ b/arch/arm/boot/dts/armada-388-gp.dts |
| @@ -89,7 +89,7 @@ |
| pinctrl-names = "default"; |
| pinctrl-0 = <&pca0_pins>; |
| interrupt-parent = <&gpio0>; |
| - interrupts = <18 IRQ_TYPE_EDGE_FALLING>; |
| + interrupts = <18 IRQ_TYPE_LEVEL_LOW>; |
| gpio-controller; |
| #gpio-cells = <2>; |
| interrupt-controller; |
| @@ -101,7 +101,7 @@ |
| compatible = "nxp,pca9555"; |
| pinctrl-names = "default"; |
| interrupt-parent = <&gpio0>; |
| - interrupts = <18 IRQ_TYPE_EDGE_FALLING>; |
| + interrupts = <18 IRQ_TYPE_LEVEL_LOW>; |
| gpio-controller; |
| #gpio-cells = <2>; |
| interrupt-controller; |
