| From c58eef061dda7d843dcc0ad6fea7e597d4c377c0 Mon Sep 17 00:00:00 2001 |
| From: Colin Ian King <colin.king@canonical.com> |
| Date: Wed, 19 Dec 2018 16:30:07 +0000 |
| Subject: staging: wilc1000: fix missing read_write setting when reading data |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| commit c58eef061dda7d843dcc0ad6fea7e597d4c377c0 upstream. |
| |
| Currently the cmd.read_write setting is not initialized so it contains |
| garbage from the stack. Fix this by setting it to 0 to indicate a |
| read is required. |
| |
| Detected by CoverityScan, CID#1357925 ("Uninitialized scalar variable") |
| |
| Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Cc: stable <stable@vger.kernel.org> |
| Acked-by: Ajay Singh <ajay.kathat@microchip.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/staging/wilc1000/wilc_sdio.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/staging/wilc1000/wilc_sdio.c |
| +++ b/drivers/staging/wilc1000/wilc_sdio.c |
| @@ -830,6 +830,7 @@ static int sdio_read_int(struct wilc *wi |
| if (!g_sdio.irq_gpio) { |
| int i; |
| |
| + cmd.read_write = 0; |
| cmd.function = 1; |
| cmd.address = 0x04; |
| cmd.data = 0; |
