| From foo@baz Fri Jan 4 20:27:35 CET 2019 |
| From: Cong Wang <xiyou.wangcong@gmail.com> |
| Date: Mon, 10 Dec 2018 12:45:45 -0800 |
| Subject: tipc: fix a double kfree_skb() |
| |
| From: Cong Wang <xiyou.wangcong@gmail.com> |
| |
| [ Upstream commit acb4a33e9856d5fa3384b87d3d8369229be06d31 ] |
| |
| tipc_udp_xmit() drops the packet on error, there is no |
| need to drop it again. |
| |
| Fixes: ef20cd4dd163 ("tipc: introduce UDP replicast") |
| Reported-and-tested-by: syzbot+eae585ba2cc2752d3704@syzkaller.appspotmail.com |
| Cc: Ying Xue <ying.xue@windriver.com> |
| Cc: Jon Maloy <jon.maloy@ericsson.com> |
| Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/tipc/udp_media.c | 4 +--- |
| 1 file changed, 1 insertion(+), 3 deletions(-) |
| |
| --- a/net/tipc/udp_media.c |
| +++ b/net/tipc/udp_media.c |
| @@ -243,10 +243,8 @@ static int tipc_udp_send_msg(struct net |
| } |
| |
| err = tipc_udp_xmit(net, _skb, ub, src, &rcast->addr); |
| - if (err) { |
| - kfree_skb(_skb); |
| + if (err) |
| goto out; |
| - } |
| } |
| err = 0; |
| out: |
