| From foo@baz Mon Apr 9 17:09:24 CEST 2018 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Wed, 14 Jun 2017 13:58:53 +0300 |
| Subject: drm/amdkfd: NULL dereference involving create_process() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| |
| [ Upstream commit b312b2b25b6ac9e2eb03f4ca651b33108752de3a ] |
| |
| We accidentally return ERR_PTR(0) which is NULL. The caller is not |
| expecting that and it leads to an Oops. |
| |
| Fixes: dd59239a9862 ("amdkfd: init aperture once per process") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Felix Kuehling <felix.kuehling@amd.com> |
| Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c |
| +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c |
| @@ -317,7 +317,8 @@ static struct kfd_process *create_proces |
| |
| /* init process apertures*/ |
| process->is_32bit_user_mode = in_compat_syscall(); |
| - if (kfd_init_apertures(process) != 0) |
| + err = kfd_init_apertures(process); |
| + if (err != 0) |
| goto err_init_apretures; |
| |
| return process; |
