| From foo@baz Mon Apr 9 17:09:24 CEST 2018 |
| From: Reza Arbab <arbab@linux.vnet.ibm.com> |
| Date: Fri, 12 May 2017 15:46:32 -0700 |
| Subject: mm, vmstat: Remove spurious WARN() during zoneinfo print |
| |
| From: Reza Arbab <arbab@linux.vnet.ibm.com> |
| |
| |
| [ Upstream commit 8d35bb310698c69d73073b26fc581f2e3f7f621d ] |
| |
| After commit e2ecc8a79ed4 ("mm, vmstat: print non-populated zones in |
| zoneinfo"), /proc/zoneinfo will show unpopulated zones. |
| |
| A memoryless node, having no populated zones at all, was previously |
| ignored, but will now trigger the WARN() in is_zone_first_populated(). |
| |
| Remove this warning, as its only purpose was to warn of a situation that |
| has since been enabled. |
| |
| Aside: The "per-node stats" are still printed under the first populated |
| zone, but that's not necessarily the first stanza any more. I'm not |
| sure which criteria is more important with regard to not breaking |
| parsers, but it looks a little weird to the eye. |
| |
| Fixes: e2ecc8a79ed4 ("mm, vmstat: print node-based stats in zoneinfo file") |
| Link: http://lkml.kernel.org/r/1493854905-10918-1-git-send-email-arbab@linux.vnet.ibm.com |
| Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> |
| Cc: David Rientjes <rientjes@google.com> |
| Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com> |
| Cc: Vlastimil Babka <vbabka@suse.cz> |
| Cc: Mel Gorman <mgorman@techsingularity.net> |
| Cc: Johannes Weiner <hannes@cmpxchg.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| mm/vmstat.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| --- a/mm/vmstat.c |
| +++ b/mm/vmstat.c |
| @@ -1351,8 +1351,6 @@ static bool is_zone_first_populated(pg_d |
| return zone == compare; |
| } |
| |
| - /* The zone must be somewhere! */ |
| - WARN_ON_ONCE(1); |
| return false; |
| } |
| |