| From foo@baz Mon Apr 9 17:09:24 CEST 2018 |
| From: Holger Brunck <holger.brunck@keymile.com> |
| Date: Wed, 17 May 2017 17:24:33 +0200 |
| Subject: net/wan/fsl_ucc_hdlc: fix unitialized variable warnings |
| |
| From: Holger Brunck <holger.brunck@keymile.com> |
| |
| |
| [ Upstream commit 66bb144bd9096dd5268ef736ba769b8b6f4ef100 ] |
| |
| This fixes the following compiler warnings: |
| drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_poll': |
| warning: 'skb' may be used uninitialized in this function |
| [-Wmaybe-uninitialized] |
| skb->mac_header = skb->data - skb->head; |
| |
| and |
| |
| drivers/net/wan/fsl_ucc_hdlc.c: In function 'ucc_hdlc_probe': |
| drivers/net/wan/fsl_ucc_hdlc.c:1127:3: warning: 'utdm' may be used |
| uninitialized in this function [-Wmaybe-uninitialized] |
| kfree(utdm); |
| |
| Signed-off-by: Holger Brunck <holger.brunck@keymile.com> |
| Cc: Zhao Qiang <qiang.zhao@nxp.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/wan/fsl_ucc_hdlc.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/net/wan/fsl_ucc_hdlc.c |
| +++ b/drivers/net/wan/fsl_ucc_hdlc.c |
| @@ -454,7 +454,7 @@ static int hdlc_tx_done(struct ucc_hdlc_ |
| static int hdlc_rx_done(struct ucc_hdlc_private *priv, int rx_work_limit) |
| { |
| struct net_device *dev = priv->ndev; |
| - struct sk_buff *skb; |
| + struct sk_buff *skb = NULL; |
| hdlc_device *hdlc = dev_to_hdlc(dev); |
| struct qe_bd *bd; |
| u32 bd_status; |
| @@ -1002,7 +1002,7 @@ static int ucc_hdlc_probe(struct platfor |
| struct device_node *np = pdev->dev.of_node; |
| struct ucc_hdlc_private *uhdlc_priv = NULL; |
| struct ucc_tdm_info *ut_info; |
| - struct ucc_tdm *utdm; |
| + struct ucc_tdm *utdm = NULL; |
| struct resource res; |
| struct net_device *dev; |
| hdlc_device *hdlc; |