| From foo@baz Mon Apr 9 17:09:24 CEST 2018 |
| From: Jason Yan <yanaijie@huawei.com> |
| Date: Thu, 4 Jan 2018 21:04:31 +0800 |
| Subject: scsi: libsas: fix memory leak in sas_smp_get_phy_events() |
| |
| From: Jason Yan <yanaijie@huawei.com> |
| |
| |
| [ Upstream commit 4a491b1ab11ca0556d2fda1ff1301e862a2d44c4 ] |
| |
| We've got a memory leak with the following producer: |
| |
| while true; |
| do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null; |
| done |
| |
| The buffer req is allocated and not freed after we return. Fix it. |
| |
| Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver") |
| Signed-off-by: Jason Yan <yanaijie@huawei.com> |
| CC: John Garry <john.garry@huawei.com> |
| CC: chenqilin <chenqilin2@huawei.com> |
| CC: chenxiang <chenxiang66@hisilicon.com> |
| Reviewed-by: Christoph Hellwig <hch@lst.de> |
| Reviewed-by: Hannes Reinecke <hare@suse.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/scsi/libsas/sas_expander.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/scsi/libsas/sas_expander.c |
| +++ b/drivers/scsi/libsas/sas_expander.c |
| @@ -684,6 +684,7 @@ int sas_smp_get_phy_events(struct sas_ph |
| phy->phy_reset_problem_count = scsi_to_u32(&resp[24]); |
| |
| out: |
| + kfree(req); |
| kfree(resp); |
| return res; |
| |
