| From foo@baz Mon Apr 9 17:09:24 CEST 2018 |
| From: Geert Uytterhoeven <geert+renesas@glider.be> |
| Date: Thu, 18 May 2017 15:01:34 +0200 |
| Subject: sh_eth: Use platform device for printing before register_netdev() |
| |
| From: Geert Uytterhoeven <geert+renesas@glider.be> |
| |
| |
| [ Upstream commit 5f5c5449acad0cd3322e53e1ac68c044483b0aa5 ] |
| |
| The MDIO initialization failure message is printed using the network |
| device, before it has been registered, leading to: |
| |
| (null): failed to initialise MDIO |
| |
| Use the platform device instead to fix this: |
| |
| sh-eth ee700000.ethernet: failed to initialise MDIO |
| |
| Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the network device") |
| Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> |
| Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/renesas/sh_eth.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/renesas/sh_eth.c |
| +++ b/drivers/net/ethernet/renesas/sh_eth.c |
| @@ -3133,7 +3133,7 @@ static int sh_eth_drv_probe(struct platf |
| /* MDIO bus init */ |
| ret = sh_mdio_init(mdp, pd); |
| if (ret) { |
| - dev_err(&ndev->dev, "failed to initialise MDIO\n"); |
| + dev_err(&pdev->dev, "failed to initialise MDIO\n"); |
| goto out_release; |
| } |
| |
