| From 35d6fcbb7c3e296a52136347346a698a35af3fda Mon Sep 17 00:00:00 2001 |
| From: Miklos Szeredi <mszeredi@redhat.com> |
| Date: Mon, 27 May 2019 11:42:07 +0200 |
| Subject: fuse: fallocate: fix return with locked inode |
| |
| From: Miklos Szeredi <mszeredi@redhat.com> |
| |
| commit 35d6fcbb7c3e296a52136347346a698a35af3fda upstream. |
| |
| Do the proper cleanup in case the size check fails. |
| |
| Tested with xfstests:generic/228 |
| |
| Reported-by: kbuild test robot <lkp@intel.com> |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Fixes: 0cbade024ba5 ("fuse: honor RLIMIT_FSIZE in fuse_file_fallocate") |
| Cc: Liu Bo <bo.liu@linux.alibaba.com> |
| Cc: <stable@vger.kernel.org> # v3.5 |
| Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/fuse/file.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/fuse/file.c |
| +++ b/fs/fuse/file.c |
| @@ -3050,7 +3050,7 @@ static long fuse_file_fallocate(struct f |
| offset + length > i_size_read(inode)) { |
| err = inode_newsize_ok(inode, offset + length); |
| if (err) |
| - return err; |
| + goto out; |
| } |
| |
| if (!(mode & FALLOC_FL_KEEP_SIZE)) |
