| From f392bb77b82cf0f3b7b1cbf34601a4c00768aac8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 25 May 2021 18:46:17 +0800 |
| Subject: ath10k: Fix an error code in ath10k_add_interface() |
| |
| From: Yang Li <yang.lee@linux.alibaba.com> |
| |
| [ Upstream commit e9ca70c735ce66fc6a0e02c8b6958434f74ef8de ] |
| |
| When the code execute this if statement, the value of ret is 0. |
| However, we can see from the ath10k_warn() log that the value of |
| ret should be -EINVAL. |
| |
| Clean up smatch warning: |
| |
| drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn: |
| missing error code 'ret' |
| |
| Reported-by: Abaci Robot <abaci@linux.alibaba.com> |
| Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine") |
| Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Link: https://lore.kernel.org/r/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/wireless/ath/ath10k/mac.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c |
| index f5c0f9bac840..36183fdfb7f0 100644 |
| --- a/drivers/net/wireless/ath/ath10k/mac.c |
| +++ b/drivers/net/wireless/ath/ath10k/mac.c |
| @@ -5482,6 +5482,7 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, |
| |
| if (arvif->nohwcrypt && |
| !test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) { |
| + ret = -EINVAL; |
| ath10k_warn(ar, "cryptmode module param needed for sw crypto\n"); |
| goto err; |
| } |
| -- |
| 2.30.2 |
| |