| From ed9efa8769a9efe90308cc1978e998d724865009 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 22 May 2021 11:50:54 +0200 |
| Subject: ath11k: Fix an error handling path in |
| ath11k_core_fetch_board_data_api_n() |
| |
| From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| |
| [ Upstream commit 515bda1d1e51c64edf2a384a58801f85a80a3f2d ] |
| |
| All error paths but this one 'goto err' in order to release some |
| resources. |
| Fix this. |
| |
| Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") |
| Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Link: https://lore.kernel.org/r/e959eb544f3cb04258507d8e25a6f12eab126bde.1621676864.git.christophe.jaillet@wanadoo.fr |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/wireless/ath/ath11k/core.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c |
| index a68fe3a45a74..28de2c7ae899 100644 |
| --- a/drivers/net/wireless/ath/ath11k/core.c |
| +++ b/drivers/net/wireless/ath/ath11k/core.c |
| @@ -329,7 +329,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab, |
| if (len < ALIGN(ie_len, 4)) { |
| ath11k_err(ab, "invalid length for board ie_id %d ie_len %zu len %zu\n", |
| ie_id, ie_len, len); |
| - return -EINVAL; |
| + ret = -EINVAL; |
| + goto err; |
| } |
| |
| switch (ie_id) { |
| -- |
| 2.30.2 |
| |