| From bd428148c72525c2038dd71df8f7f9e72c318414 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 10 May 2021 12:57:16 +0300 |
| Subject: backlight: lm3630a_bl: Put fwnode in error case during ->probe() |
| |
| From: Andy Shevchenko <andy.shevchenko@gmail.com> |
| |
| [ Upstream commit 6d1c32dbedd7d7e7372aa38033ec8782c39f6379 ] |
| |
| device_for_each_child_node() bumps a reference counting of a returned variable. |
| We have to balance it whenever we return to the caller. |
| |
| Cc: Brian Masney <masneyb@onstation.org> |
| Cc: Dan Murphy <dmurphy@ti.com> |
| Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support") |
| Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Reviewed-by: Brian Masney <masneyb@onstation.org> |
| Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> |
| Signed-off-by: Lee Jones <lee.jones@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/backlight/lm3630a_bl.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c |
| index e88a2b0e5904..662029d6a3dc 100644 |
| --- a/drivers/video/backlight/lm3630a_bl.c |
| +++ b/drivers/video/backlight/lm3630a_bl.c |
| @@ -482,8 +482,10 @@ static int lm3630a_parse_node(struct lm3630a_chip *pchip, |
| |
| device_for_each_child_node(pchip->dev, node) { |
| ret = lm3630a_parse_bank(pdata, node, &seen_led_sources); |
| - if (ret) |
| + if (ret) { |
| + fwnode_handle_put(node); |
| return ret; |
| + } |
| } |
| |
| return ret; |
| -- |
| 2.30.2 |
| |
