| From 5e6b8a50a7cec5686ee2c4bda1d49899c79a7eae Mon Sep 17 00:00:00 2001 |
| From: Yang Yingliang <yangyingliang@huawei.com> |
| Date: Wed, 26 May 2021 22:38:05 +0800 |
| Subject: cred: add missing return error code when set_cred_ucounts() failed |
| |
| From: Yang Yingliang <yangyingliang@huawei.com> |
| |
| commit 5e6b8a50a7cec5686ee2c4bda1d49899c79a7eae upstream. |
| |
| If set_cred_ucounts() failed, we need return the error code. |
| |
| Fixes: 905ae01c4ae2 ("Add a reference to ucounts for each cred") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> |
| Link: https://lkml.kernel.org/r/20210526143805.2549649-1-yangyingliang@huawei.com |
| Reviewed-by: Alexey Gladkov <legion@kernel.org> |
| Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| kernel/cred.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/kernel/cred.c |
| +++ b/kernel/cred.c |
| @@ -372,7 +372,8 @@ int copy_creds(struct task_struct *p, un |
| ret = create_user_ns(new); |
| if (ret < 0) |
| goto error_put; |
| - if (set_cred_ucounts(new) < 0) |
| + ret = set_cred_ucounts(new); |
| + if (ret < 0) |
| goto error_put; |
| } |
| |
