| From a53a18b879150f65dce99a62c12ff0359d1e4611 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 16 May 2021 08:58:04 +0200 |
| Subject: crypto: ccp - Fix a resource leak in an error handling path |
| |
| From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| |
| [ Upstream commit a6f8e68e238a15bb15f1726b35c695136c64eaba ] |
| |
| If an error occurs after calling 'sp_get_irqs()', 'sp_free_irqs()' must be |
| called as already done in the error handling path. |
| |
| Fixes: f4d18d656f88 ("crypto: ccp - Abstract interrupt registeration") |
| Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| Acked-by: John Allen <john.allen@amd.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/crypto/ccp/sp-pci.c | 6 ++++-- |
| 1 file changed, 4 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c |
| index f471dbaef1fb..7d346d842a39 100644 |
| --- a/drivers/crypto/ccp/sp-pci.c |
| +++ b/drivers/crypto/ccp/sp-pci.c |
| @@ -222,7 +222,7 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) |
| if (ret) { |
| dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n", |
| ret); |
| - goto e_err; |
| + goto free_irqs; |
| } |
| } |
| |
| @@ -230,10 +230,12 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) |
| |
| ret = sp_init(sp); |
| if (ret) |
| - goto e_err; |
| + goto free_irqs; |
| |
| return 0; |
| |
| +free_irqs: |
| + sp_free_irqs(sp); |
| e_err: |
| dev_notice(dev, "initialization failed\n"); |
| return ret; |
| -- |
| 2.30.2 |
| |
