| From a76c63b809c572751885be3f0f96a6f57aa9b918 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 1 Jun 2021 22:51:18 +0800 |
| Subject: crypto: omap-sham - Fix PM reference leak in omap sham ops |
| |
| From: Zhang Qilong <zhangqilong3@huawei.com> |
| |
| [ Upstream commit ca323b2c61ec321eb9f2179a405b9c34cdb4f553 ] |
| |
| pm_runtime_get_sync will increment pm usage counter |
| even it failed. Forgetting to putting operation will |
| result in reference leak here. We fix it by replacing |
| it with pm_runtime_resume_and_get to keep usage counter |
| balanced. |
| |
| Fixes: 604c31039dae4 ("crypto: omap-sham - Check for return value from pm_runtime_get_sync") |
| Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/crypto/omap-sham.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c |
| index a3b38d2c92e7..39d17ed1db2f 100644 |
| --- a/drivers/crypto/omap-sham.c |
| +++ b/drivers/crypto/omap-sham.c |
| @@ -371,7 +371,7 @@ static int omap_sham_hw_init(struct omap_sham_dev *dd) |
| { |
| int err; |
| |
| - err = pm_runtime_get_sync(dd->dev); |
| + err = pm_runtime_resume_and_get(dd->dev); |
| if (err < 0) { |
| dev_err(dd->dev, "failed to get sync: %d\n", err); |
| return err; |
| @@ -2243,7 +2243,7 @@ static int omap_sham_suspend(struct device *dev) |
| |
| static int omap_sham_resume(struct device *dev) |
| { |
| - int err = pm_runtime_get_sync(dev); |
| + int err = pm_runtime_resume_and_get(dev); |
| if (err < 0) { |
| dev_err(dev, "failed to get sync: %d\n", err); |
| return err; |
| -- |
| 2.30.2 |
| |
