| From 7be7690ba8d5bf3dfbea98ba1c8dfc651e21f3d2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 19 Apr 2021 11:01:24 +0200 |
| Subject: drm/bridge/sii8620: fix dependency on extcon |
| |
| From: Robert Foss <robert.foss@linaro.org> |
| |
| [ Upstream commit 08319adbdde15ef7cee1970336f63461254baa2a ] |
| |
| The DRM_SIL_SII8620 kconfig has a weak `imply` dependency |
| on EXTCON, which causes issues when sii8620 is built |
| as a builtin and EXTCON is built as a module. |
| |
| The symptoms are 'undefined reference' errors caused |
| by the symbols in EXTCON not being available |
| to the sii8620 driver. |
| |
| Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL") |
| Reported-by: kernel test robot <lkp@intel.com> |
| Signed-off-by: Robert Foss <robert.foss@linaro.org> |
| Reviewed-by: Randy Dunlap <rdunlap@infradead.org> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20210419090124.153560-1-robert.foss@linaro.org |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/bridge/Kconfig | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig |
| index e145cbb35bac..4e82647a621e 100644 |
| --- a/drivers/gpu/drm/bridge/Kconfig |
| +++ b/drivers/gpu/drm/bridge/Kconfig |
| @@ -130,7 +130,7 @@ config DRM_SIL_SII8620 |
| tristate "Silicon Image SII8620 HDMI/MHL bridge" |
| depends on OF |
| select DRM_KMS_HELPER |
| - imply EXTCON |
| + select EXTCON |
| depends on RC_CORE || !RC_CORE |
| help |
| Silicon Image SII8620 HDMI/MHL bridge chip driver. |
| -- |
| 2.30.2 |
| |