| From 3fc716d23cb29066d3a68b33edde6419ac829f72 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 8 May 2021 10:28:36 +0800 |
| Subject: drm/msm: Fix error return code in msm_drm_init() |
| |
| From: Zhen Lei <thunder.leizhen@huawei.com> |
| |
| [ Upstream commit a1c9b1e3bdd6d8dc43c18699772fb6cf4497d45a ] |
| |
| Fix to return a negative error code from the error handling case instead |
| of 0, as done elsewhere in this function. |
| |
| Fixes: 7f9743abaa79 ("drm/msm: validate display and event threads") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> |
| Link: https://lore.kernel.org/r/20210508022836.1777-1-thunder.leizhen@huawei.com |
| Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> |
| Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> |
| Signed-off-by: Rob Clark <robdclark@chromium.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/msm/msm_drv.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c |
| index 0aacc43faefa..edee4c2a76ce 100644 |
| --- a/drivers/gpu/drm/msm/msm_drv.c |
| +++ b/drivers/gpu/drm/msm/msm_drv.c |
| @@ -505,6 +505,7 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) |
| priv->event_thread[i].worker = kthread_create_worker(0, |
| "crtc_event:%d", priv->event_thread[i].crtc_id); |
| if (IS_ERR(priv->event_thread[i].worker)) { |
| + ret = PTR_ERR(priv->event_thread[i].worker); |
| DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n"); |
| goto err_msm_uninit; |
| } |
| -- |
| 2.30.2 |
| |
