| From 8e16b13a9a4247414122c0792205ac248d42f3b3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 1 May 2021 17:13:16 +0200 |
| Subject: drm/rockchip: lvds: Fix an error handling path |
| |
| From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| |
| [ Upstream commit 3dfa159f6b0c054eb63673fbf643a5f2cc862e63 ] |
| |
| 'ret' is know to be 0 a this point. Checking the return value of |
| 'phy_init()' and 'phy_set_mode()' was intended instead. |
| |
| So add the missing assignments. |
| |
| Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support") |
| Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| Signed-off-by: Heiko Stuebner <heiko@sntech.de> |
| Link: https://patchwork.freedesktop.org/patch/msgid/248220d4815dc8c8088cebfab7d6df5f70518438.1619881852.git.christophe.jaillet@wanadoo.fr |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c |
| index 41edd0a421b2..7c20b4a24a7e 100644 |
| --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c |
| +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c |
| @@ -499,11 +499,11 @@ static int px30_lvds_probe(struct platform_device *pdev, |
| if (IS_ERR(lvds->dphy)) |
| return PTR_ERR(lvds->dphy); |
| |
| - phy_init(lvds->dphy); |
| + ret = phy_init(lvds->dphy); |
| if (ret) |
| return ret; |
| |
| - phy_set_mode(lvds->dphy, PHY_MODE_LVDS); |
| + ret = phy_set_mode(lvds->dphy, PHY_MODE_LVDS); |
| if (ret) |
| return ret; |
| |
| -- |
| 2.30.2 |
| |