| From 13404247b6c5689c9b272c4fb7ee4a9105941eea Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 8 Jun 2021 01:17:55 +0300 |
| Subject: eeprom: idt_89hpesx: Put fwnode in matching case during ->probe() |
| |
| From: Andy Shevchenko <andy.shevchenko@gmail.com> |
| |
| [ Upstream commit 3f6ee1c095156a74ab2df605af13020f1ce3e600 ] |
| |
| device_get_next_child_node() bumps a reference counting of a returned variable. |
| We have to balance it whenever we return to the caller. |
| |
| Fixes: db15d73e5f0e ("eeprom: idt_89hpesx: Support both ACPI and OF probing") |
| Cc: Huy Duong <qhuyduong@hotmail.com> |
| Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Link: https://lore.kernel.org/r/20210607221757.81465-1-andy.shevchenko@gmail.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/misc/eeprom/idt_89hpesx.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c |
| index 81c70e5bc168..45a61a1f9e98 100644 |
| --- a/drivers/misc/eeprom/idt_89hpesx.c |
| +++ b/drivers/misc/eeprom/idt_89hpesx.c |
| @@ -1161,6 +1161,7 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev) |
| else /* if (!fwnode_property_read_bool(node, "read-only")) */ |
| pdev->eero = false; |
| |
| + fwnode_handle_put(fwnode); |
| dev_info(dev, "EEPROM of %d bytes found by 0x%x", |
| pdev->eesize, pdev->eeaddr); |
| } |
| -- |
| 2.30.2 |
| |
