| From 45027d8b11422edc81b5b4268cb738346f4686f0 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 8 Jun 2021 01:17:56 +0300 |
| Subject: eeprom: idt_89hpesx: Restore printing the unsupported fwnode name |
| |
| From: Andy Shevchenko <andy.shevchenko@gmail.com> |
| |
| [ Upstream commit e0db3deea73ba418bf5dc21f5a4e32ca87d16dde ] |
| |
| When iterating over child firmware nodes restore printing the name of ones |
| that are not supported. |
| |
| While at it, refactor loop body to clearly show that we stop at the first match. |
| |
| Fixes: db15d73e5f0e ("eeprom: idt_89hpesx: Support both ACPI and OF probing") |
| Cc: Huy Duong <qhuyduong@hotmail.com> |
| Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Link: https://lore.kernel.org/r/20210607221757.81465-2-andy.shevchenko@gmail.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/misc/eeprom/idt_89hpesx.c | 7 +++---- |
| 1 file changed, 3 insertions(+), 4 deletions(-) |
| |
| diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c |
| index 45a61a1f9e98..3e4a594c110b 100644 |
| --- a/drivers/misc/eeprom/idt_89hpesx.c |
| +++ b/drivers/misc/eeprom/idt_89hpesx.c |
| @@ -1126,11 +1126,10 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev) |
| |
| device_for_each_child_node(dev, fwnode) { |
| ee_id = idt_ee_match_id(fwnode); |
| - if (!ee_id) { |
| - dev_warn(dev, "Skip unsupported EEPROM device"); |
| - continue; |
| - } else |
| + if (ee_id) |
| break; |
| + |
| + dev_warn(dev, "Skip unsupported EEPROM device %pfw\n", fwnode); |
| } |
| |
| /* If there is no fwnode EEPROM device, then set zero size */ |
| -- |
| 2.30.2 |
| |