| From d5a1c8d2dbee8cd90bd7bf1a828f7d864033ca75 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 31 May 2021 15:34:35 +0200 |
| Subject: extcon: sm5502: Drop invalid register write in sm5502_reg_data |
| |
| From: Stephan Gerhold <stephan@gerhold.net> |
| |
| [ Upstream commit d25b224f8e5507879b36a769a6d1324cf163466c ] |
| |
| When sm5502_init_dev_type() iterates over sm5502_reg_data to |
| initialize the registers it is limited by ARRAY_SIZE(sm5502_reg_data). |
| There is no need to add another empty element to sm5502_reg_data. |
| |
| Having the additional empty element in sm5502_reg_data will just |
| result in writing 0xff to register 0x00, which does not really |
| make sense. |
| |
| Fixes: 914b881f9452 ("extcon: sm5502: Add support new SM5502 extcon device driver") |
| Signed-off-by: Stephan Gerhold <stephan@gerhold.net> |
| Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/extcon/extcon-sm5502.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c |
| index 106d4da647bd..5e0718dee03b 100644 |
| --- a/drivers/extcon/extcon-sm5502.c |
| +++ b/drivers/extcon/extcon-sm5502.c |
| @@ -88,7 +88,6 @@ static struct reg_data sm5502_reg_data[] = { |
| | SM5502_REG_INTM2_MHL_MASK, |
| .invert = true, |
| }, |
| - { } |
| }; |
| |
| /* List of detectable cables */ |
| -- |
| 2.30.2 |
| |