| From 5d49d3508b3c67201bd3e1bf7f4ef049111b7051 Mon Sep 17 00:00:00 2001 |
| From: Andreas Gruenbacher <agruenba@redhat.com> |
| Date: Mon, 28 Jun 2021 19:14:50 +0800 |
| Subject: gfs2: Fix error handling in init_statfs |
| |
| From: Andreas Gruenbacher <agruenba@redhat.com> |
| |
| commit 5d49d3508b3c67201bd3e1bf7f4ef049111b7051 upstream. |
| |
| On an error path, init_statfs calls iput(pn) after pn has already been put. |
| Fix that by setting pn to NULL after the initial iput. |
| |
| Fixes: 97fd734ba17e ("gfs2: lookup local statfs inodes prior to journal recovery") |
| Cc: stable@vger.kernel.org # v5.10+ |
| Reported-by: Jing Xiangfeng <jingxiangfeng@huawei.com> |
| Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/gfs2/ops_fstype.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/fs/gfs2/ops_fstype.c |
| +++ b/fs/gfs2/ops_fstype.c |
| @@ -670,6 +670,7 @@ static int init_statfs(struct gfs2_sbd * |
| } |
| |
| iput(pn); |
| + pn = NULL; |
| ip = GFS2_I(sdp->sd_sc_inode); |
| error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, |
| &sdp->sd_sc_gh); |