| From fba2c30b07b615ec7beda339ae4c0a35f4bff4d2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 22 Apr 2021 12:19:04 +0200 |
| Subject: iio: adis16400: do not return ints in irq handlers |
| |
| From: Nuno Sa <nuno.sa@analog.com> |
| |
| [ Upstream commit ab3df79782e7d8a27a58576c9b4e8c6c4879ad79 ] |
| |
| On an IRQ handler we should not return normal error codes as 'irqreturn_t' |
| is expected. |
| |
| Not necessary to apply to stable as the original check cannot fail and |
| as such the bug cannot actually occur. |
| |
| Fixes: 5eda3550a3cc1 ("staging:iio:adis16400: Preallocate transfer message") |
| Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> |
| Signed-off-by: Nuno Sa <nuno.sa@analog.com> |
| Link: https://lore.kernel.org/r/20210422101911.135630-3-nuno.sa@analog.com |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/iio/imu/adis16400.c | 3 --- |
| 1 file changed, 3 deletions(-) |
| |
| diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c |
| index 785a4ce606d8..4aff16466da0 100644 |
| --- a/drivers/iio/imu/adis16400.c |
| +++ b/drivers/iio/imu/adis16400.c |
| @@ -647,9 +647,6 @@ static irqreturn_t adis16400_trigger_handler(int irq, void *p) |
| void *buffer; |
| int ret; |
| |
| - if (!adis->buffer) |
| - return -ENOMEM; |
| - |
| if (!(st->variant->flags & ADIS16400_NO_BURST) && |
| st->adis.spi->max_speed_hz > ADIS16400_SPI_BURST) { |
| st->adis.spi->max_speed_hz = ADIS16400_SPI_BURST; |
| -- |
| 2.30.2 |
| |
