| From 6b27cc303b437e8090663010d840542a73dd844d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 22 Apr 2021 12:19:03 +0200 |
| Subject: iio: adis_buffer: do not return ints in irq handlers |
| |
| From: Nuno Sa <nuno.sa@analog.com> |
| |
| [ Upstream commit d877539ad8e8fdde9af69887055fec6402be1a13 ] |
| |
| On an IRQ handler we should not return normal error codes as 'irqreturn_t' |
| is expected. |
| |
| Not necessarily stable material as the old check cannot fail, so it's a bug |
| we can not hit. |
| |
| Fixes: ccd2b52f4ac69 ("staging:iio: Add common ADIS library") |
| Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> |
| Signed-off-by: Nuno Sa <nuno.sa@analog.com> |
| Link: https://lore.kernel.org/r/20210422101911.135630-2-nuno.sa@analog.com |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/iio/imu/adis_buffer.c | 3 --- |
| 1 file changed, 3 deletions(-) |
| |
| diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.c |
| index ac354321f63a..175af154e443 100644 |
| --- a/drivers/iio/imu/adis_buffer.c |
| +++ b/drivers/iio/imu/adis_buffer.c |
| @@ -129,9 +129,6 @@ static irqreturn_t adis_trigger_handler(int irq, void *p) |
| struct adis *adis = iio_device_get_drvdata(indio_dev); |
| int ret; |
| |
| - if (!adis->buffer) |
| - return -ENOMEM; |
| - |
| if (adis->data->has_paging) { |
| mutex_lock(&adis->state_lock); |
| if (adis->current_page != 0) { |
| -- |
| 2.30.2 |
| |
