| From 78e50724639e7012f3c9be992dafd84761ddc3d4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 10 May 2021 12:50:18 +0300 |
| Subject: leds: class: The -ENOTSUPP should never be seen by user space |
| |
| From: Andy Shevchenko <andy.shevchenko@gmail.com> |
| |
| [ Upstream commit 0ac40af86077982a5346dbc9655172d2775d6b08 ] |
| |
| Drop the bogus error code and let of_led_get() to take care about absent |
| of_node. |
| |
| Fixes: e389240ad992 ("leds: Add managed API to get a LED from a device driver") |
| Cc: Jean-Jacques Hiblot <jjhiblot@ti.com> |
| Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Signed-off-by: Pavel Machek <pavel@ucw.cz> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/leds/led-class.c | 4 ---- |
| 1 file changed, 4 deletions(-) |
| |
| diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c |
| index 131ca83f5fb3..4365c1cc4505 100644 |
| --- a/drivers/leds/led-class.c |
| +++ b/drivers/leds/led-class.c |
| @@ -286,10 +286,6 @@ struct led_classdev *__must_check devm_of_led_get(struct device *dev, |
| if (!dev) |
| return ERR_PTR(-EINVAL); |
| |
| - /* Not using device tree? */ |
| - if (!IS_ENABLED(CONFIG_OF) || !dev->of_node) |
| - return ERR_PTR(-ENOTSUPP); |
| - |
| led = of_led_get(dev->of_node, index); |
| if (IS_ERR(led)) |
| return led; |
| -- |
| 2.30.2 |
| |