| From 2cdd59a6de188b4254c6767fd9267a585bc596c9 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 10 May 2021 12:50:33 +0300 |
| Subject: leds: lm36274: Put fwnode in error case during ->probe() |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Andy Shevchenko <andy.shevchenko@gmail.com> |
| |
| [ Upstream commit 3c5f655c44bb65cb7e3c219d08c130ce5fa45d7f ] |
| |
| device_get_next_child_node() bumps a reference counting of a returned variable. |
| We have to balance it whenever we return to the caller. |
| |
| In the older code the same is implied with device_for_each_child_node(). |
| |
| Fixes: 11e1bbc116a7 ("leds: lm36274: Introduce the TI LM36274 LED driver") |
| Fixes: a448fcf19c9c ("leds: lm36274: don't iterate through children since there is only one") |
| Cc: Dan Murphy <dmurphy@ti.com> |
| Cc: Marek Behรบn <marek.behun@nic.cz> |
| Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Signed-off-by: Pavel Machek <pavel@ucw.cz> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/leds/leds-lm36274.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c |
| index aadb03468a40..a23a9424c2f3 100644 |
| --- a/drivers/leds/leds-lm36274.c |
| +++ b/drivers/leds/leds-lm36274.c |
| @@ -127,6 +127,7 @@ static int lm36274_probe(struct platform_device *pdev) |
| |
| ret = lm36274_init(chip); |
| if (ret) { |
| + fwnode_handle_put(init_data.fwnode); |
| dev_err(chip->dev, "Failed to init the device\n"); |
| return ret; |
| } |
| -- |
| 2.30.2 |
| |
