| From fe1a0d2e443be22348ca530ad84b9b7bc6f2c84c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 10 May 2021 12:50:39 +0300 |
| Subject: leds: lm3697: Don't spam logs when probe is deferred |
| |
| From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| |
| [ Upstream commit 807553f8bf4afa673750e52905e0f9488179112f ] |
| |
| When requesting GPIO line the probe can be deferred. |
| In such case don't spam logs with an error message. |
| This can be achieved by switching to dev_err_probe(). |
| |
| Fixes: 5c1d824cda9f ("leds: lm3697: Introduce the lm3697 driver") |
| Cc: Dan Murphy <dmurphy@ti.com> |
| Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Signed-off-by: Pavel Machek <pavel@ucw.cz> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/leds/leds-lm3697.c | 8 +++----- |
| 1 file changed, 3 insertions(+), 5 deletions(-) |
| |
| diff --git a/drivers/leds/leds-lm3697.c b/drivers/leds/leds-lm3697.c |
| index 7d216cdb91a8..912e8bb22a99 100644 |
| --- a/drivers/leds/leds-lm3697.c |
| +++ b/drivers/leds/leds-lm3697.c |
| @@ -203,11 +203,9 @@ static int lm3697_probe_dt(struct lm3697 *priv) |
| |
| priv->enable_gpio = devm_gpiod_get_optional(dev, "enable", |
| GPIOD_OUT_LOW); |
| - if (IS_ERR(priv->enable_gpio)) { |
| - ret = PTR_ERR(priv->enable_gpio); |
| - dev_err(dev, "Failed to get enable gpio: %d\n", ret); |
| - return ret; |
| - } |
| + if (IS_ERR(priv->enable_gpio)) |
| + return dev_err_probe(dev, PTR_ERR(priv->enable_gpio), |
| + "Failed to get enable GPIO\n"); |
| |
| priv->regulator = devm_regulator_get(dev, "vled"); |
| if (IS_ERR(priv->regulator)) |
| -- |
| 2.30.2 |
| |