| From 137c4f8a110a131aa486bd604d3eb009e0a474d5 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 10 May 2021 12:50:40 +0300 |
| Subject: leds: lp50xx: Put fwnode in error case during ->probe() |
| |
| From: Andy Shevchenko <andy.shevchenko@gmail.com> |
| |
| [ Upstream commit f1e1d532da7e6ef355528a22fb97d9a8fbf76c4e ] |
| |
| fwnode_for_each_child_node() bumps a reference counting of a returned variable. |
| We have to balance it whenever we return to the caller. |
| |
| OTOH, the successful iteration will drop reference count under the hood, no need |
| to do it twice. |
| |
| Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver") |
| Cc: Dan Murphy <dmurphy@ti.com> |
| Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Signed-off-by: Pavel Machek <pavel@ucw.cz> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/leds/leds-lp50xx.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c |
| index f13117eed976..d4529082935b 100644 |
| --- a/drivers/leds/leds-lp50xx.c |
| +++ b/drivers/leds/leds-lp50xx.c |
| @@ -496,6 +496,7 @@ static int lp50xx_probe_dt(struct lp50xx *priv) |
| ret = fwnode_property_read_u32(led_node, "color", |
| &color_id); |
| if (ret) { |
| + fwnode_handle_put(led_node); |
| dev_err(priv->dev, "Cannot read color\n"); |
| goto child_out; |
| } |
| @@ -519,7 +520,6 @@ static int lp50xx_probe_dt(struct lp50xx *priv) |
| goto child_out; |
| } |
| i++; |
| - fwnode_handle_put(child); |
| } |
| |
| return 0; |
| -- |
| 2.30.2 |
| |
