| From cbddff79a1179a405d6a5fbc677983de0829eae6 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 28 Apr 2021 09:38:56 +0200 |
| Subject: media: s5p_cec: decrement usage count if disabled |
| |
| From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| |
| [ Upstream commit 747bad54a677d8633ec14b39dfbeb859c821d7f2 ] |
| |
| There's a bug at s5p_cec_adap_enable(): if called to |
| disable the device, it should call pm_runtime_put() |
| instead of pm_runtime_disable(), as the goal here is to |
| decrement the usage_count and not to disable PM runtime. |
| |
| Reported-by: Sylwester Nawrocki <s.nawrocki@samsung.com> |
| Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Fixes: 1bcbf6f4b6b0 ("[media] cec: s5p-cec: Add s5p-cec driver") |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/cec/platform/s5p/s5p_cec.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/media/cec/platform/s5p/s5p_cec.c b/drivers/media/cec/platform/s5p/s5p_cec.c |
| index 2250c1cbc64e..028a09a7531e 100644 |
| --- a/drivers/media/cec/platform/s5p/s5p_cec.c |
| +++ b/drivers/media/cec/platform/s5p/s5p_cec.c |
| @@ -54,7 +54,7 @@ static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable) |
| } else { |
| s5p_cec_mask_tx_interrupts(cec); |
| s5p_cec_mask_rx_interrupts(cec); |
| - pm_runtime_disable(cec->dev); |
| + pm_runtime_put(cec->dev); |
| } |
| |
| return 0; |
| -- |
| 2.30.2 |
| |
