| From 06d19e05c56542f8a653873a3aca1966a5b15278 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 10 Jun 2021 08:57:02 +0200 |
| Subject: media: siano: fix device register error path |
| |
| From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| |
| [ Upstream commit 5368b1ee2939961a16e74972b69088433fc52195 ] |
| |
| As reported by smatch: |
| drivers/media/common/siano/smsdvb-main.c:1231 smsdvb_hotplug() warn: '&client->entry' not removed from list |
| |
| If an error occur at the end of the registration logic, it won't |
| drop the device from the list. |
| |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/common/siano/smsdvb-main.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| diff --git a/drivers/media/common/siano/smsdvb-main.c b/drivers/media/common/siano/smsdvb-main.c |
| index ae17407e477a..7cc654bc52d3 100644 |
| --- a/drivers/media/common/siano/smsdvb-main.c |
| +++ b/drivers/media/common/siano/smsdvb-main.c |
| @@ -1176,6 +1176,10 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev, |
| return 0; |
| |
| media_graph_error: |
| + mutex_lock(&g_smsdvb_clientslock); |
| + list_del(&client->entry); |
| + mutex_unlock(&g_smsdvb_clientslock); |
| + |
| smsdvb_debugfs_release(client); |
| |
| client_error: |
| -- |
| 2.30.2 |
| |
