| From 18dbe01419f80301875ee337b2540eb7cdd5ccaf Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 19 May 2021 14:04:49 +0200 |
| Subject: media: st-hva: Fix potential NULL pointer dereferences |
| |
| From: Evgeny Novikov <novikov@ispras.ru> |
| |
| [ Upstream commit b7fdd208687ba59ebfb09b2199596471c63b69e3 ] |
| |
| When ctx_id >= HVA_MAX_INSTANCES in hva_hw_its_irq_thread() it tries to |
| access fields of ctx that is NULL at that point. The patch gets rid of |
| these accesses. |
| |
| Found by Linux Driver Verification project (linuxtesting.org). |
| |
| Signed-off-by: Evgeny Novikov <novikov@ispras.ru> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/platform/sti/hva/hva-hw.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c |
| index 43f279e2a6a3..cf4c891bf619 100644 |
| --- a/drivers/media/platform/sti/hva/hva-hw.c |
| +++ b/drivers/media/platform/sti/hva/hva-hw.c |
| @@ -130,8 +130,7 @@ static irqreturn_t hva_hw_its_irq_thread(int irq, void *arg) |
| ctx_id = (hva->sts_reg & 0xFF00) >> 8; |
| if (ctx_id >= HVA_MAX_INSTANCES) { |
| dev_err(dev, "%s %s: bad context identifier: %d\n", |
| - ctx->name, __func__, ctx_id); |
| - ctx->hw_err = true; |
| + HVA_PREFIX, __func__, ctx_id); |
| goto out; |
| } |
| |
| -- |
| 2.30.2 |
| |
