| From e9fe9a4fb1e2edaa8ff8ac0a0949ef80028d9f9b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 15 May 2021 08:58:30 +0200 |
| Subject: media: tc358743: Fix error return code in tc358743_probe_of() |
| |
| From: Zhen Lei <thunder.leizhen@huawei.com> |
| |
| [ Upstream commit a6b1e7093f0a099571fc8836ab4a589633f956a8 ] |
| |
| When the CSI bps per lane is not in the valid range, an appropriate error |
| code -EINVAL should be returned. However, we currently do not explicitly |
| assign this error code to 'ret'. As a result, 0 was incorrectly returned. |
| |
| Fixes: 256148246852 ("[media] tc358743: support probe from device tree") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/i2c/tc358743.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c |
| index 1b309bb743c7..f21da11caf22 100644 |
| --- a/drivers/media/i2c/tc358743.c |
| +++ b/drivers/media/i2c/tc358743.c |
| @@ -1974,6 +1974,7 @@ static int tc358743_probe_of(struct tc358743_state *state) |
| bps_pr_lane = 2 * endpoint.link_frequencies[0]; |
| if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) { |
| dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane); |
| + ret = -EINVAL; |
| goto disable_clk; |
| } |
| |
| -- |
| 2.30.2 |
| |
