| From 2692246f443013745aeca2b4efaf76d1e3fefd98 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 18 Jun 2021 19:14:31 +0300 |
| Subject: net: ethernet: ezchip: fix UAF in nps_enet_remove |
| |
| From: Pavel Skripkin <paskripkin@gmail.com> |
| |
| [ Upstream commit e4b8700e07a86e8eab6916aa5c5ba99042c34089 ] |
| |
| priv is netdev private data, but it is used |
| after free_netdev(). It can cause use-after-free when accessing priv |
| pointer. So, fix it by moving free_netdev() after netif_napi_del() |
| call. |
| |
| Fixes: 0dd077093636 ("NET: Add ezchip ethernet driver") |
| Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/ezchip/nps_enet.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c |
| index 815fb62c4b02..026a3ec19b6e 100644 |
| --- a/drivers/net/ethernet/ezchip/nps_enet.c |
| +++ b/drivers/net/ethernet/ezchip/nps_enet.c |
| @@ -645,8 +645,8 @@ static s32 nps_enet_remove(struct platform_device *pdev) |
| struct nps_enet_priv *priv = netdev_priv(ndev); |
| |
| unregister_netdev(ndev); |
| - free_netdev(ndev); |
| netif_napi_del(&priv->napi); |
| + free_netdev(ndev); |
| |
| return 0; |
| } |
| -- |
| 2.30.2 |
| |
