| From f911713bb86d9a098bef6f3bb43e6e9803990957 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 10 May 2021 12:58:05 +0300 |
| Subject: net: mvpp2: Put fwnode in error case during ->probe() |
| |
| From: Andy Shevchenko <andy.shevchenko@gmail.com> |
| |
| [ Upstream commit 71f0891c84dfdc448736082ab0a00acd29853896 ] |
| |
| In each iteration fwnode_for_each_available_child_node() bumps a reference |
| counting of a loop variable followed by dropping in on a next iteration, |
| |
| Since in error case the loop is broken, we have to drop a reference count |
| by ourselves. Do it for port_fwnode in error case during ->probe(). |
| |
| Fixes: 248122212f68 ("net: mvpp2: use device_*/fwnode_* APIs instead of of_*") |
| Cc: Marcin Wojtas <mw@semihalf.com> |
| Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c |
| index 6aa13c9f9fc9..a9f65d667761 100644 |
| --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c |
| +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c |
| @@ -7045,6 +7045,8 @@ static int mvpp2_probe(struct platform_device *pdev) |
| return 0; |
| |
| err_port_probe: |
| + fwnode_handle_put(port_fwnode); |
| + |
| i = 0; |
| fwnode_for_each_available_child_node(fwnode, port_fwnode) { |
| if (priv->port_list[i]) |
| -- |
| 2.30.2 |
| |
