| From e6e2b4409144416ebe91a3d3d53cf322ac091e13 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 2 Jun 2021 18:05:48 +0800 |
| Subject: platform/x86: toshiba_acpi: Fix missing error code in |
| toshiba_acpi_setup_keyboard() |
| |
| From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> |
| |
| [ Upstream commit 28e367127718a9cb85d615a71e152f7acee41bfc ] |
| |
| The error code is missing in this code scenario, add the error code |
| '-EINVAL' to the return value 'error'. |
| |
| Eliminate the follow smatch warning: |
| |
| drivers/platform/x86/toshiba_acpi.c:2834 toshiba_acpi_setup_keyboard() |
| warn: missing error code 'error'. |
| |
| Reported-by: Abaci Robot <abaci@linux.alibaba.com> |
| Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> |
| Link: https://lore.kernel.org/r/1622628348-87035-1-git-send-email-jiapeng.chong@linux.alibaba.com |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/platform/x86/toshiba_acpi.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c |
| index fa7232ad8c39..352508d30467 100644 |
| --- a/drivers/platform/x86/toshiba_acpi.c |
| +++ b/drivers/platform/x86/toshiba_acpi.c |
| @@ -2831,6 +2831,7 @@ static int toshiba_acpi_setup_keyboard(struct toshiba_acpi_dev *dev) |
| |
| if (!dev->info_supported && !dev->system_event_supported) { |
| pr_warn("No hotkey query interface found\n"); |
| + error = -EINVAL; |
| goto err_remove_filter; |
| } |
| |
| -- |
| 2.30.2 |
| |
